Fix crash when WINDOW_UPDATE follows GOAWAY with buffered stream data#365
Open
manas-chaudhari wants to merge 1 commit intoninenines:masterfrom
Open
Fix crash when WINDOW_UPDATE follows GOAWAY with buffered stream data#365manas-chaudhari wants to merge 1 commit intoninenines:masterfrom
manas-chaudhari wants to merge 1 commit intoninenines:masterfrom
Conversation
When a GOAWAY frame removes streams from gun's map but does not inform
cow_http2_machine, a subsequent WINDOW_UPDATE triggers send_data in the
machine which finds buffered data for the removed stream and returns it,
causing gun_http2 to look up the stream in its now-smaller map and crash
with {badkey, StreamID}.
This happens regardless of whether the frames arrive in the same or
separate TCP segments.
Fix: call cow_http2_machine:reset_stream/2 for each stream removed
by the GOAWAY handler so the machine no longer holds buffered data
for those streams.
7ae61b6 to
2a61d0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a GOAWAY frame removes streams from gun's map but does not inform cow_http2_machine, a subsequent WINDOW_UPDATE triggers send_data in the machine which finds buffered data for the removed stream and returns it, causing gun_http2 to look up the stream in its now-smaller map and crash with {badkey, StreamID}.
This happens regardless of whether the frames arrive in the same or separate TCP segments.
Fix: call cow_http2_machine:reset_stream/2 for each stream removed by the GOAWAY handler so the machine no longer holds buffered data for those streams.
Test failure before fix