Skip to content

radio-active: honor package and settings options - #9725

Open
khaneliman wants to merge 1 commit into
nix-community:masterfrom
khaneliman:fix/radio-active-contracts
Open

radio-active: honor package and settings options#9725
khaneliman wants to merge 1 commit into
nix-community:masterfrom
khaneliman:fix/radio-active-contracts

Conversation

@khaneliman

Copy link
Copy Markdown
Collaborator

Description

Honor programs.radio-active.package for installation and player-specific
patching, while preserving config and alias generation when the package is
null.

Generate any declared INI section and correct the option example to match the
nested settings type. Custom derivations without overrideAttrs remain
installable unchanged.

Adds coverage for null packages, custom mpv/vlc packages, null postPatch, raw
derivations, and non-AppConfig sections.

Tested with nix run path:.#tests -- radio-active.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -A dev --run treefmt.

  • Code tested through nix build .#test-all
    or a targeted nix run .#tests -- <pattern>.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

Use the configured package for installation and player-specific patching, while preserving configuration generation when package is null. Generate any declared INI section and correct the settings example to match the nested section type.
@github-actions github-actions Bot added the audio label Jul 28, 2026
@home-manager-ci
home-manager-ci Bot requested a review from S0AndS0 July 28, 2026 11:37
@S0AndS0

S0AndS0 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Thanks for catching, and fixing, some of my past self's mistakes!

One thing I'll forewarn of is; NixOS/nixpkgs may need the src updated to point back to up-stream maintainer's repo instead of my fork, because up-stream should be compatible with XDG_ some-time after deep5050/radio-active#124 and deep5050/radio-active:915a97

Edits

2026-07-29 01:26

Looks like updating radio-active within NixOS/nixpkgs is going to be painful, perhaps too painful, because one of its new dependences is marked broken :-/

error: Package ‘python3.13-shazamio-0.8.1’ in /home/s0ands0/git/hub/NixOS/nixpkgs/wt/radio-active/pkgs/development/python-modules/shazamio/default.nix:71 is marked as broken, refusing to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants