radio-active: honor package and settings options - #9725
Open
khaneliman wants to merge 1 commit into
Open
Conversation
Use the configured package for installation and player-specific patching, while preserving configuration generation when package is null. Generate any declared INI section and correct the settings example to match the nested section type.
Member
|
Thanks for catching, and fixing, some of my past self's mistakes! One thing I'll forewarn of is; Edits2026-07-29 01:26Looks like updating
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Honor
programs.radio-active.packagefor installation and player-specificpatching, while preserving config and alias generation when the package is
null.
Generate any declared INI section and correct the option example to match the
nested settings type. Custom derivations without
overrideAttrsremaininstallable unchanged.
Adds coverage for null packages, custom mpv/vlc packages, null
postPatch, rawderivations, and non-
AppConfigsections.Tested with
nix run path:.#tests -- radio-active.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -A dev --run treefmt.Code tested through
nix build .#test-allor a targeted
nix run .#tests -- <pattern>.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.