Drop macOS SDKs that follow "the old way"#335
Merged
nmattia merged 1 commit intonix-community:masterfrom Dec 4, 2024
Merged
Conversation
grahamc
requested review from
Anderssorby,
Patryk27,
blitz and
nmattia
as code owners
Nixpkgs now has much more reasonable handling of macOS SDKs, and this old default is not generally needed for builds anymore. I think having these SDKs in the inputs is a bit of a nuisance now, since it means there are mixed framework versions in the closure. See: https://discourse.nixos.org/t/on-the-future-of-darwin-sdks-or-how-you-can-stop-worrying-and-put-the-sdk-in-build-inputs/50574 See: NixOS/nixpkgs#346043
Collaborator
|
Oh that's very good news! I haven't been following changes in nixpkgs but this definitely cleans things up a fair bit. Thanks a lot! |
nmattia
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nixpkgs now has much more reasonable handling of macOS SDKs, and this old default is not generally needed for builds anymore.
I think having these SDKs in the inputs is a bit of a nuisance now, since it means there are mixed framework versions in the closure.
See: https://discourse.nixos.org/t/on-the-future-of-darwin-sdks-or-how-you-can-stop-worrying-and-put-the-sdk-in-build-inputs/50574
See: NixOS/nixpkgs#346043
Note: this is also tagged at https://github.com/DeterminateSystems/naersk/releases/tag/apple-sdks for use.