-
Notifications
You must be signed in to change notification settings - Fork 0
Canonicalize create and recovery route paths #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -259,9 +259,9 @@ features: | |||||||||
| - docs/ROUND_REVIEW_ACCURACY_REPORT.md | ||||||||||
| code: | ||||||||||
| routes: | ||||||||||
| - src/app/golf/(dashboard)/dashboard/rounds/new/** | ||||||||||
| - src/app/golf/(dashboard)/dashboard/rounds/create/** | ||||||||||
| - src/app/golf/(dashboard)/dashboard/rounds/continue/** | ||||||||||
| - src/app/golf/(dashboard)/dashboard/rounds/recover/** | ||||||||||
| - src/app/golf/(dashboard)/dashboard/rounds/recover-draft-draft/** | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The feature registry glob points at
Suggested change
Context Used: AGENTS.md (source) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| components: | ||||||||||
| - src/components/golf/ShotTrackingComprehensive.tsx | ||||||||||
| - src/components/golf/rounds/** | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching and discarding every
page.gotofailure means that if/,/golf, or/baseballtimes out or fails to load, Axe will run against the previous/blank document and the test can pass without ever scanning the critical route. Redirects should still resolve fromgoto, so keep the navigation failure visible or assert the final URL before analyzing.Useful? React with 👍 / 👎.