fix(baseball): hub sub-nav truncation (li→flex) + e2e idle-cliff cookie fix - #940
Conversation
…suite The seeded storageState pins the idle-activity marker at auth-setup time, so any test starting >5min (SESSION_IDLE_TIMEOUT_MS) after setup is bounced to /login by the middleware idle gate before measuring — the blocking suite passed or failed on runtime proximity to that cliff (train run 29623264998 crossed it at coach test 29 / player test 60; the earlier green run simply finished under it). An active-viewport test should look like an active user. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMdviLDsAg2YYJ8adsM6fg
…ot a flex container Completes 62b3d56 (#927): min-w-0 on the li zeroed its shrink floor, but the li was never display:flex, so the anchor inside stayed a natural-width inline-flex box in block context — truncate had no width pressure and the li shrinking just let the anchor overflow it. CI forensics on debug/clip-forensics (run 29625702166): strip scrollWidth 325 vs clientWidth 320 at 320px with fonts=loaded; prior green runs measured before the webfont swap and passed on fallback-font width. li -> flex min-w-0, anchor -> min-w-0. Also carries the e2e idle-cliff fix (refresh sb_last_activity per navigation) from fix/e2e-idle-activity-cliff so both mobile-suite fixes land together. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMdviLDsAg2YYJ8adsM6fg
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 Mission Control — PR summary What it changes (2 files, tightly scoped):
Risk / areas: Baseball hub sub-nav (mobile layout only) + the e2e mobile-viewport harness. Low blast radius — no product logic, no server/RLS/data changes. What reviewers should watch:
CI status: Read-only Mission Control sweep — no merge/deploy/settings actions taken. |
fix(a11y+e2e): landing/signup contrast (real) + auth spec drift — latent failures unmasked by #940
Bundles the two fixes that make the blocking mobile suite honestly green:
flex min-w-0, anchor →min-w-0— completes fix(baseball): mobile shell header/nav controls clipped at 320/390px on every dashboard route #927. The li wasdisplay:list-item, so the anchor was never width-constrained andtruncatenever engaged; tabs sat at natural width and the strip scrolled, clipping the last tab ("Operations"/"Postgame Review") at 320/390px. CI forensics (run 29625702166): stripscrollWidth 325vsclientWidth 320withfonts=loaded— earlier green runs measured before the webfont swap and passed on fallback-font luck. Not a train regression; a latent gap in fix(baseball): mobile shell header/nav controls clipped at 320/390px on every dashboard route #927 exposed by slower compile → later measurement.sb_last_activityper navigation (supersedes fix(e2e): mobile-viewport suite bounced by 5-min idle gate, not layout #939) — the seeded storageState pinned the idle marker at setup time, so tests starting >5min after setup were bounced to /login by the middleware idle gate.Full e2e (incl. blocking baseball mobile + seeded) dispatched on this branch.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MMdviLDsAg2YYJ8adsM6fg