fix: remove initializer modifier from child contracts#64
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initializer modifier is already being used during
when calling
super.initialize. So it's not needed in the child contracts.This was currently preventing me from deploying using Create3 because it wouldn't allow me to do a 2 step deployment (first deploying the proxy and then initializing it). Since we are setting the owner as msg.sender during initialization:
when passing the initData to Create3 it would set the owner as the temporary proxy that is created and destroying during the deployment using Create3 (which is some random address, making us lose ownership of the contract), therefore I first deploy without initializing and then initialize it immediately after deployed with the deployer's key. Unfortunately having multiple "initializer" modifiers invalidates initializing in 2 steps because with multiple initializer modifiers in the inheritance chain, 2-step initialization only works during constructor context (address(this).code.length == 0) and we can't do it during constructor context because we want the owner to be msg.sender.