Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web/websocket/websocket.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class WebSocket extends EventTarget {
#handler = {
onConnectionEstablished: (response, extensions) => this.#onConnectionEstablished(response, extensions),
onMessage: (opcode, data) => this.#onMessage(opcode, data),
onParserError: (err) => failWebsocketConnection(this.#handler, null, err.message),
onParserError: (err) => failWebsocketConnection(this.#handler, 1002, err.message),
onParserDrain: () => this.#onParserDrain(),
onSocketData: (chunk) => {
if (!this.#parser.write(chunk)) {
Expand Down
34 changes: 34 additions & 0 deletions test/websocket/parser-error-close-code.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
'use strict'

const { test } = require('node:test')
const { WebSocketServer } = require('ws')
const { WebSocket } = require('../..')
const { ByteParser } = require('../../lib/web/websocket/receiver')

test('Parser errors close the connection with 1002 (Protocol Error)', async (t) => {
const originalWrite = ByteParser.prototype._write
ByteParser.prototype._write = function (chunk, enc, cb) {
this.emit('error', new Error('simulated parser error'))
cb()
}
t.after(() => {
ByteParser.prototype._write = originalWrite
})

const server = new WebSocketServer({ port: 0, host: '127.0.0.1' })
await new Promise((resolve) => server.on('listening', resolve))
t.after(() => server.close())

const receivedCode = new Promise((resolve) => {
server.on('connection', (serverWs) => {
serverWs.on('close', (code) => resolve(code))
// Trigger the patched parser with any valid frame (a PING).
serverWs._socket.write(Buffer.from([0x89, 0x00]))
})
})

const ws = new WebSocket(`ws://127.0.0.1:${server.address().port}`)
t.after(() => ws.close())

t.assert.strictEqual(await receivedCode, 1002)
})
Loading