Added behavior for a long press on image cells. And added podspec back in. - #110
Open
crspybits wants to merge 2 commits into
Open
Added behavior for a long press on image cells. And added podspec back in.#110crspybits wants to merge 2 commits into
crspybits wants to merge 2 commits into
Conversation
Various people were wondering why. And I needed it too.
crspybits
changed the title
rizumi
self-requested a review
December 13, 2019 08:13
rizumi
reviewed
Dec 13, 2019
rizumi
left a comment
rizumi
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the very late confirmation.
Please separate podfile modifications and create another pull request.
Thanks for contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new member variable:
for NohanaImagePickerController allows a long press to be used to show the large images. In this case, a tap on the main part of the cell just changed the picked state.
I added this because in my case two different actions when tapping different parts of the cell seemed difficult for a user.
I've also added the Cocoapods podspec back in. Various people were wondering why it was removed (#101) and I needed it too.