chore(brillig): Make codegen_mov_registers_to_registers general again and use it in jmp - #13307
Open
aakoshh wants to merge 4 commits into
Open
chore(brillig): Make codegen_mov_registers_to_registers general again and use it in jmp#13307aakoshh wants to merge 4 commits into
codegen_mov_registers_to_registers general again and use it in jmp#13307aakoshh wants to merge 4 commits into
Conversation
aakoshh
marked this pull request as ready for review
July 8, 2026 12:10
5 tasks
aakoshh
added a commit
that referenced
this pull request
Jul 8, 2026
… in jmp Phase 0 prerequisite for the pluggable allocator seam (Phase 0.5). resolve_edge will wrap the revived any-to-any mover this introduces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
One of the phases in #13302
#10305 made this routine iterative, but also added a constraint that made it usable only for return values. This could have been used in linear scan during jumps; the current
jmphandler used an ad-hoc method that grabs more temporary registers than the general routine would do to handle cycles.Summary of Changes
codegen_mov_registers_to_registersto remove the restriction that destinations have to be consecutive memory registerscodegen_mov_registers_to_registersto handle aconditionand emitconditional_mov.codegen_mov_registers_to_registersfromjmp_setupUser Documentation
Check one:
PR Checklist
cargo fmton default settings.