fix(frontend): ignore unreachable breaks in raw loop validation - #13344
Draft
AztecBot wants to merge 1 commit into
Draft
fix(frontend): ignore unreachable breaks in raw loop validation#13344AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
TomAFrench
force-pushed
the
cb/noir-audit-remediation-1041-loop-break-reachability
branch
from
July 29, 2026 10:49
32e8b5e to
f31af8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raw
loopvalidation now ignoresbreakstatements that are inside compile-time-dead literalifbranches. This keeps the frontend's infinite-loop rejection aligned with the SSA lowering path that removes those dead branches before loop codegen.Fix
if true/if falseconditions.if false { break; }andif true { continue; } else { break; }inside raw loops.Testing
cargo test -p noirc_frontend loop_with_break -- --nocapturecargo test -p noirc_frontend errors_if_loop_body_type_is_not_unit -- --nocapturecargo fmtIssues
loopaccepted statically unreachable breaks and could compile to an endless Brillig functionCreated by claudebox · group:
noir-audit-remediation