fix(ci): pin aztec-packages commit in compile-noir-contracts job

[AztecBot]

Problem

The compile-noir-contracts job ("Compile noir-contracts zero inliner aggressiveness") in .github/workflows/test-js-packages.yml checks out AztecProtocol/aztec-packages with no ref:, so it always compiles against the live tip of that repo's default branch (next) at the moment CI runs. That's a moving target: the same Noir PR can be green one hour and red the next purely because next advanced, with no change on the Noir side.

This surfaced on noir-lang/noir#13346, where the job failed with Comptime variable 'seed' cannot be used in runtime code in aztec-nr's oracle_testing.nr. Building nargo from both master and that PR and compiling against the next commit CI happened to pick up (48f6b87) reproduced the failure identically — so the breakage came from an aztec next ↔ noir-beta.23 mismatch that landed on next between the green baseline run and the PR run, not from the PR.

Every other aztec-packages consumer in the repo already pins: the external-repo-checks matrix and the benchmark jobs resolve ref from &AZ_COMMIT in EXTERNAL_NOIR_LIBRARIES.yml (and .github/benchmark_projects.yml), which the weekly bump-aztec-packages-commit workflow advances via a reviewed PR. Only this one job was left floating.

Fix

Resolve the pinned commit from EXTERNAL_NOIR_LIBRARIES.yml's define field and pass it as the checkout ref, so this job tracks the exact same commit as external-repo-checks and gets bumped in lockstep by the existing bump-aztec-packages-commit workflow (which already edits that file). yq is already relied on for the same file by scripts/bump-aztec-packages-commit.sh and is preinstalled on the GitHub ubuntu-22.04 runner.

- name: Resolve pinned aztec-packages commit
  id: aztec-commit
  run: echo "commit=$(yq '.define' ./noir-repo/EXTERNAL_NOIR_LIBRARIES.yml)" >> "$GITHUB_OUTPUT"

- name: Checkout
  uses: actions/checkout@... # v7.0.0
  with:
    repository: AztecProtocol/aztec-packages
    ref: ${{ steps.aztec-commit.outputs.commit }}
    path: test-repo

After this, an aztec next breakage can no longer redden unrelated Noir PRs; it only surfaces when the pin is bumped, where it's expected and reviewable.

---

Created by claudebox · group: slackbot