fix(nargo): include validation policy in artifact cache reuse - #13389
Open
1sgtpepper wants to merge 1 commit into
Open
fix(nargo): include validation policy in artifact cache reuse#133891sgtpepper wants to merge 1 commit into
1sgtpepper wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
1sgtpepper
force-pushed
the
fix-cache-validation-policy
branch
from
July 22, 2026 12:00
93ebbbe to
d799bb6
Compare
1sgtpepper
marked this pull request as ready for review
July 22, 2026 12:01
1sgtpepper
force-pushed
the
fix-cache-validation-policy
branch
from
July 22, 2026 12:48
d799bb6 to
b1e916b
Compare
1sgtpepper
force-pushed
the
fix-cache-validation-policy
branch
from
July 22, 2026 13:08
b1e916b to
642a2fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
Resolves #12843
Summary of Changes
Prevents a compile from reusing a program artifact produced with incompatible compilation or validation options. The existing artifact hash now covers the monomorphized program and every option that can affect the persisted artifact or cached diagnostics.
This keeps the fix inside the cache owner and adds no artifact field or serialization surface; artifacts carrying the old source-only hash naturally miss once and are rebuilt. Diagnostic-only modes that need fresh output force compilation without becoming persistent identity. End-to-end
nargo compileregressions prove that default validation is rerun after both checks were skipped and that cached compilation warnings are reevaluated when warning policy changes.User Documentation
Check one:
PR Checklist
cargo fmton default settings.Validation:
cargo test -p noirc_artifacts --libcargo test -p noirc_driver --libcargo test -p nargo_cli --test compile_cachecargo check -p nargocargo clippy -p noirc_driver -p noirc_artifacts --lib -- -D warningscargo clippy -p nargo_cli --test compile_cache -- -D warningscargo fmt --check