fix: don't consider &mut x as a last use in a call if x is used in another argument - #13446
Open
asterite wants to merge 5 commits into
Open
fix: don't consider &mut x as a last use in a call if x is used in another argument#13446asterite wants to merge 5 commits into
asterite wants to merge 5 commits into
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
Resolves https://github.com/noir-lang/noir-claude/issues/1553
Resolves https://github.com/noir-lang/noir-claude/issues/1563
Summary of Changes
This fixes a real bug where passing
&mut x, xto a call didn't produce a clone onxso a mutation via&mut x(in the called method) ended up affectingx. That said, this is unlikely to happen in real code as there's probably no use in passing the same variable both as a mutable reference and as itself.Then, a fix to rc_invariant had to be done to account for this case. This is a check that runs in debug builds.
User Documentation
Check one:
PR Checklist
cargo fmton default settings.