fix(scripts): Fix unreliable port exits that causes racing conditions - #49
Open
Savio-Sou wants to merge 3 commits into
Open
fix(scripts): Fix unreliable port exits that causes racing conditions#49Savio-Sou wants to merge 3 commits into
Savio-Sou wants to merge 3 commits into
Conversation
Savio-Sou
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
This came from running
scripts/check-critical-libraries.sh.When oracle tests of sha256, poseidon, and keccak256 were ran consecutively, the same port 8095 they rely on were not freed up in time for the next tests to run on, ended up in failing oracles tests.
Summary of Changes
Strengthen port cleanup, and add error for when RPC server fails to start.
PR Checklist
cargo fmton default settings.