-
Notifications
You must be signed in to change notification settings - Fork 764
Add On-Chain Send/Receive to NWC #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barrydeen
wants to merge
9
commits into
nostr-protocol:master
Choose a base branch
from
barrydeen:dev-nip47-chain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+193
−2
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
29970b4
add on-chain payments to nwc
barrydeen 081f770
list utxos, sign psbt, confirmed balanced
barrydeen 888e132
optional psbt index
barrydeen 89e07e5
disabled formatter
barrydeen 3bcfc62
add optional to address type
barrydeen d10ce4c
input index is optional
barrydeen 6da5912
decouple chain methods from lightning
barrydeen 9c8e54d
unix timestamp, add address
barrydeen 4472f8b
multiple inputs/outputs to chain txns, feerate, confirmed bal
barrydeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should happen if the backend is not able to pay all adresses but only some (e.g. too few funds)?
Might add a line saying something alike:
All given addresses have to be paid in a single transaction or the request gets failed.This should give the client the explicit guarantee that the transaction will happen as requested.