Open
Conversation
Avoid touching generated files when content is unchanged by introducing a shared writeIfChanged helper and routing all Kawarimi output writes through it. This preserves output mtimes and reduces downstream recompilation in incremental builds.
Make KawarimiTests depend on the executable target and add direct unit tests for GeneratedFileWriter.writeIfChanged. This validates both skip-on-same-content and overwrite-on-diff behavior without relying on full CLI execution.
Kawarimi
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratedFileWriter.writeIfChangedand route all Kawarimi generated output writes through it.writeIfChangedbehavior and updateKawarimiTeststarget dependency for direct function testing.Test plan
swift test --filter KawarimiTestswriteIfChangedskips write on identical contentwriteIfChangedoverwrites file when content differs