372 standardize fringe fit locit - #374
Open
vsmagalhaes wants to merge 60 commits into
Open
Conversation
…o allow for use in fringefit_locit.py
…saving data to xds.
…data produced by the difference method in the report; Changed how the --delay-limits option work so that they can be used properly inside ipython.
… AstrohackBaseFile (Allowing for all the plots from the locit_mds to be done in the position_mds.py).
… of locit_mds functions work when called from a position_mds object.
…fo for locit plots use.
…fo for locit plots use.
…uction_pipeline.py.
…tion file itself.
9 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## astrohack-dev #374 +/- ##
=================================================
+ Coverage 62.53% 64.31% +1.77%
=================================================
Files 61 61
Lines 9889 9944 +55
=================================================
+ Hits 6184 6395 +211
+ Misses 3705 3549 -156 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is meant to close issue #372.
fringefit_locit is a new tool intended to help produce antenna position corrections when an antenna position is very poorly known.
This pull request also includes lots of minor changes caused by applying ruff to the source code.
Good to bring attention here is that the black cli failed for a few files even after ruff, mostly trailing comma issues.
Also in this PR is the removal of largely obsolete code that has not been maintained or used for over 3 years.