sal: fix stale BLE advert state on deinit and reconnect#789
Open
ktaborowski wants to merge 1 commit into
Open
Conversation
Reset adv_state when advertising stops on connect or during deinit, and guard set_adv_data when adv_set is NULL. Add unit tests for connected stop/deinit/restart and failed-stop recovery paths. Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>
LuDuda
approved these changes
Jul 17, 2026
LuDuda
left a comment
Contributor
There was a problem hiding this comment.
Was this true for Add-On 1.2 as well? If yes, we might want to add a known-issue as well. Otherwise LGTM 👍
.config diff.config change: https://github.com/nrfconnect/sdk-sidewalk/actions/runs/29583242900/artifacts/8407893864 Configuration diff too long to fit. Check file in artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset adv_state when advertising stops on connect or during deinit, and guard set_adv_data when adv_set is NULL. Add unit tests for connected stop/deinit/restart and failed-stop recovery paths.
Issue scenario (fixed): Sidewalk FSK Ready -> switch to LoRa -> wait for Ready -> Fault
CI parameters
Description
JIRA ticket:
Self review