New keypad button design - #288
Draft
Vogtinator wants to merge 1 commit into
Draft
Conversation
Vogtinator
marked this pull request as draft
December 25, 2022 19:48
Represent the button pressed state as raising/lowering the button. Hovering is shown separately by a change in color.
Vogtinator
force-pushed
the
newkeypaddesign
branch
from
January 7, 2023 16:56
2167fbb to
0ca36fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent the button pressed state as raising/lowering the button. Hovering
is shown separately by a change in color.
Opinions? IMO the only downside is that it's not quite as obvious on first sight whether a key is pressed.
recording.webm
Depends on #287.
TODO: