Translate tuple parameters through the list translator#891
Open
8rief wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tuple parameter values currently fall through to the generic escaped-string translation path. This changes their type in generated parameter cells, including when a tuple is nested inside a dictionary.
This change routes tuples through the existing list translator. It preserves the tuple's values while producing the JSON-compatible list representation recommended in the issue discussion. A regression case covers a nested tuple matching the reported configuration shape.
Fixes #784
Verification
pytest papermill/tests/test_translators.py -k test_translate_type_python -qpytest papermill/tests/test_translators.py -qpytest -qpre-commit run --files papermill/translators.py papermill/tests/test_translators.pyAll 548 tests and the changed-file pre-commit hooks passed locally.