Skip to content

Perf: Replace full SVD with torch.svd_lowrank for acceleration #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lantudou wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Perf: Replace full SVD with torch.svd_lowrank for acceleration #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions deepcompressor/nn/patch/lowrank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,12 @@ def reset_parameters(self, weight: torch.Tensor | None = None) -> None:
if self.rank < 0:
self.a.weight.data.copy_(weight)
elif self.rank > 0:
u, s, vh = torch.linalg.svd(weight.double())
# tensor: [oc, ic], u: [oc, oc], s: [oc], vh: [ic, ic]
buffer = 10
u, s, v = torch.svd_lowrank(weight.double(), q=self.rank + buffer, niter=4)
# tensor: [oc, ic], u: [oc, q], s: [q], v: [ic, q]
# us: [oc, rank], vh: [rank, ic]
us = u[:, : self.rank] * s[: self.rank]
vh = vh[: self.rank]
vh = v[:, : self.rank].t()
assert not us.isnan().any(), "NaN in U * S"
assert not vh.isnan().any(), "NaN in V^T"
assert not us.isinf().any(), "Inf in U * S"
Expand Down