[Xu JiaChen]iP#60
Open
aaronxujiachen wants to merge 29 commits into
Open
Conversation
TriciaBK
reviewed
Sep 7, 2023
| } | ||
| } else if (input.startsWith("mark") || input.startsWith("unmark")) { | ||
| // Split the input to separate command and task index | ||
| String[] arrOfInput = input.split(" ", 2); |
There was a problem hiding this comment.
naming "arrOfInput" can be clearer to indicate that it stores the split of the input
| System.out.println(message); | ||
| System.out.println(" " + tasks.get(index).getStatusIcon() + " " + tasks.get(index).description); | ||
| } | ||
| } catch (NumberFormatException e) { |
There was a problem hiding this comment.
try-catch statementfollows coding standard
karishma-t
reviewed
Sep 7, 2023
| drawLine(); | ||
| } | ||
|
|
||
| // Main method |
There was a problem hiding this comment.
good use of encapsulation and methods of sufficient-length
| System.out.println("What can I do for you?"); | ||
| drawLine(); | ||
| } | ||
|
|
There was a problem hiding this comment.
sufficiently comprehensible comments
irving11119
reviewed
Sep 17, 2023
irving11119
left a comment
irving11119
left a comment
There was a problem hiding this comment.
Overall your code is well organised and it follows the coding standards. It is also very readable. The only suggestion I would have is look into using constants rather than magic types.
|
|
||
| // Method to print the logo and introductory message | ||
| public static void hiDude() { | ||
| String logo = "### # \n" |
There was a problem hiding this comment.
Perhaps this logo could be implemented as a constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.