[Barbaracwx] iP#67
Conversation
| return description; | ||
| } | ||
|
|
||
| public String getStatusIcon() { |
| return (isDone ? "X" : " "); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Good use of @OverRide to show overriding of parent's method
| System.out.println("Nice! I've marked this task as done:\n" + tasks[taskIndex].toString()); | ||
| } | ||
| } else { | ||
| String[] parts = line.split(" ", 2); |
There was a problem hiding this comment.
Good use of plurality for naming "parts"
| String command = parts[0]; | ||
| String taskDescription = parts.length > 1 ? parts[1] : ""; | ||
|
|
||
| switch (command) { |
There was a problem hiding this comment.
Right use of indentation for switch case
yicheng-toh
left a comment
yicheng-toh
left a comment
There was a problem hiding this comment.
Code mostly follows required standard and quality.
| package PACKAGE_NAME;public class DeadlineTask { | ||
| } |
There was a problem hiding this comment.
You might want to add some spaces between the package and the class.
| package PACKAGE_NAME;public class DeadlineTask { | |
| } | |
| package PACKAGE_NAME; | |
| public class DeadlineTask { | |
| } |
| case "event": | ||
| tasks[taskCount] = new EventTask(taskDescription); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I like how you handle invalid inputs for the switch case.
| String command = parts[0]; | ||
| String taskDescription = parts.length > 1 ? parts[1] : ""; | ||
|
|
||
| switch (command) { |
There was a problem hiding this comment.
Perhaps you could consider creating a separate method for the switch case
YongbinWang
left a comment
YongbinWang
left a comment
There was a problem hiding this comment.
Overall good job so far. You followed the coding standards well, good practice of OOP concepts as well. Keep up the good work!
| Task[] tasks = new Task[100]; | ||
| int taskCount = 0; | ||
|
|
||
| String line = input.nextLine(); |
There was a problem hiding this comment.
Consider changing your variable name to something more appropriate such as userInput.
Implement find
Added JavaDoc comments
4 participants
No description provided.