imaginarys96 iP by imaginarys96 · Pull Request #73 · nus-cs2113-AY2324S1/ip

imaginarys96 · 2023-09-05T07:23:23Z

No description provided.

spinoandraptos · 2023-09-06T04:39:06Z

    protected boolean isDone;
-
-    public Task(String description) {
+    protected String type;


type is ambiguous, can be mistaken as a verb, recommend to use taskType

spinoandraptos · 2023-09-06T04:44:41Z

                System.out.println("____________________________________________________________");
-            } else if ( input.startsWith("mark ") ) {
+            } else if (input.startsWith("mark ")) {
                String number = input.replace("mark ", "").trim();


number is ambiguous, recommend to use taskNumber

spinoandraptos · 2023-09-06T04:46:27Z

-            } else if ( input.startsWith("mark ") ) {
+            } else if (input.startsWith("mark ")) {
                String number = input.replace("mark ", "").trim();
                int markTaskNo = Integer.parseInt(number);


noun should not be named with a verb in it, recommend to combine with previous line and use taskNumber as previously mentioned

spinoandraptos · 2023-09-06T04:47:54Z

-                if( markTaskNo > 0 ) {
-                    tasks[markTaskNo-1].markAsDone();
+                if (markTaskNo > 0) {
+                    tasks[markTaskNo - 1].markAsDone();


using -1 magical number, would be good to define what the -1 means

spinoandraptos · 2023-09-06T04:48:47Z

-            } else if ( input.startsWith("unmark ") ) {
+            } else if (input.startsWith("unmark ")) {
                String number = input.replace("unmark ", "").trim();
                int unmarkTaskNo = Integer.parseInt(number);


variable name can be mistaken as an action, recommend to use unmarkedTaskNo

spinoandraptos · 2023-09-06T04:52:35Z

-                System.out.println( "   ["  + tasks[unmarkTaskNo-1].getStatusIcon() + "] " + tasks[unmarkTaskNo-1].getDescription() );
+                System.out.println("   [" + tasks[unmarkTaskNo - 1].getStatusIcon() + "] " + tasks[unmarkTaskNo - 1].getDescription());
+                System.out.println("____________________________________________________________");
+            } else if ( input.startsWith("todo") ) {


unnecessary spaces for start and ends of brackets

spinoandraptos · 2023-09-06T04:54:12Z

        this.isDone = false;
    }

+    public String getTypeIcon() { return type; }


curly bracket should start on a newline

Musfirahe0556596

Overall good job but some coding quality and standards to follow!

Musfirahe0556596 · 2023-09-16T12:10:25Z

@@ -0,0 +1,128 @@
+package chatbot;
+
+import chatbot.*;


Imported classes should always be listed explicitly (avoid *)

Musfirahe0556596 · 2023-09-16T12:11:03Z

+
+public class Chatbot {
+
+    public static void main(String[] args) throws Exception {


Avoid long methods of more than 30 LoC

Musfirahe0556596 · 2023-09-16T12:11:18Z

+                    System.out.println("____________________________________________________________");
+                    System.out.println(" Here are the tasks in your list:");
+                    for (int i = 0; i < numOfTasks; i++) {
+                        //System.out.println(" " + (i + 1) + ".[" + tasks[i].getTypeIcon() + "][" + tasks[i].getStatusIcon() + "] " + tasks[i].getDescription());


Remove commented code

Musfirahe0556596 · 2023-09-16T12:12:33Z

+                    System.out.println("   [" + tasks[unmarkedTaskNo - 1].getStatusIcon() + "] " + tasks[unmarkedTaskNo - 1].getDescription());
+                    System.out.println("____________________________________________________________");
+                } else if (input.startsWith("todo")) {
+                    String msg = input.replace("todo", "").trim();


Avoid foreign language words, slang, and names (msg)

Musfirahe0556596 · 2023-09-16T12:12:48Z

+                    System.out.println(" Now you have " + String.valueOf(numOfTasks) + " tasks in the list.");
+                    System.out.println("____________________________________________________________");
+                }  else if (input.startsWith("deadline")) {
+                    String msg = input.replace("deadline", "").trim();


Avoid foreign language words, slang, and names (msg)

Musfirahe0556596 · 2023-09-16T12:12:59Z

+                    }
+
+                    String byDate = msg.substring(msg.indexOf("/by ") + 4).trim(); // will contain the byDate
+                    String desc = msg.substring(0, msg.indexOf("/by")); // will contain the deadline description


Avoid foreign language words, slang, and names (desc)

Musfirahe0556596 · 2023-09-16T12:13:13Z

+                    System.out.println(" Now you have " + String.valueOf(numOfTasks) + " tasks in the list.");
+                    System.out.println("____________________________________________________________");
+                } else if (input.startsWith("event")) {
+                    String msg = input.replace("event", "").trim();


Avoid foreign language words, slang, and names (msg)

Musfirahe0556596 · 2023-09-16T12:13:23Z

+                    String dateRange = msg.substring(msg.indexOf("/from ") + 6).trim();
+                    String fromDate = dateRange.substring(0, dateRange.indexOf("/to ")).trim();
+                    String toDate = dateRange.substring(dateRange.indexOf("/to ") + 4).trim();
+                    String desc = msg.substring(0, msg.indexOf("/from ")); // will contain the deadline description


Avoid foreign language words, slang, and names (desc)

text-ui-test/runtest.bat|sh scripts generate a file ACTUAL.TXT. However, .gitignore uses ACTUAL.txt, which means the generated file will not be ignored by Git on non-Windows OS. Let's update .gitignore as ACTUAL.txt -> ACTUAL.TXT

Final improvements

imaginer96 added 6 commits August 31, 2023 12:57

Rename Duke to Chatbot

08758df

Implemented skeletal chatbot functionality

70db08d

Implemented Level 1 - echo, bye

f199592

Implemented Level 2 - Add, list

74cd269

Implemented Level 3 - Mark as Done

89fbf7b

Level 4. ToDos, Events, Deadlines implemented

c78ca99

spinoandraptos reviewed Sep 6, 2023

View reviewed changes

imaginer96 added 5 commits September 6, 2023 16:42

A-Inheritance Implemented

fc69e5c

Implemented Level-5 with Exceptions

725a683

Merge branch 'branch-Level-5'

7f288f7

Implemented A-Packages

6d91851

Merge branch 'branch-A-Packages'

45634a7

Musfirahe0556596 reviewed Sep 16, 2023

View reviewed changes

imaginer96 added 6 commits September 20, 2023 11:14

Implemented Level-6 with A-Collections using ArrayList

05dfeaf

Implemented Level-7

c6f11a2

Merge branch 'branch-Level-6'

0321771

Fixed bug where Task status was not saved in storage file

5526242

Removed static variable numOfTask

a608f54

Removed numOfTask variable references

5e2946d

imaginer96 added 2 commits October 6, 2023 23:07

Implemented A-MoreOOP

46504a4

Implemented A-MoreOOP

5b89da7

imaginarys96 force-pushed the master branch from 46504a4 to 5e2946d Compare October 6, 2023 15:20

imaginer96 added 7 commits October 6, 2023 23:41

Implemented branch-Level-9

c33523b

A-UserGuide

2026fdf

Modified user guide

0465ace

update docs

3c63edf

extracted most .println calls from Command to the Ui class

8b4c583

added command package

0838b6a

Refactored if-else commands to individual classes

1e16cf3

imaginer96 and others added 3 commits October 24, 2023 16:47

fixed bug where program exists upon exception

ba940d1

added function comments

888536f

Merge pull request #1 from imaginarys96/FinalImprovements

5cc3861

Final improvements


		public class Chatbot {

		public static void main(String[] args) throws Exception {

Uh oh!

Conversation

imaginarys96 commented Sep 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Musfirahe0556596 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants