[Ee Hong Zhi] ip by Hongzhii · Pull Request #78 · nus-cs2113-AY2324S1/ip

Hongzhii · 2023-09-06T03:05:05Z

No description provided.

implement inheritance for Event, Deadline, Todo classes

skylee03

Aside from violating coding guidelines a bit, well done!

skylee03 · 2023-09-07T09:37:18Z

@@ -0,0 +1,19 @@
+public class Deadline extends Task{


Suggested change

public class Deadline extends Task{

public class Deadline extends Task {

Adding a space before the curly bracket is more consistent with our coding conventions.

skylee03 · 2023-09-07T09:39:01Z

@@ -0,0 +1,19 @@
+public class Deadline extends Task{
+    private String deadline;
+    public Deadline(String description, String deadline){


Suggested change

public Deadline(String description, String deadline){

public Deadline(String description, String deadline) {

Adding a space before the curly bracket is more consistent with our coding conventions.

skylee03 · 2023-09-07T09:40:22Z

+    }
+
+    @Override
+    public void show(){


Suggested change

public void show(){

public void show() {

Adding a space before the curly bracket is more consistent with our coding conventions.

skylee03 · 2023-09-07T09:41:38Z

+        }
+        else{


Suggested change

}

else{

} else {

According to our coding standards, it is recommended to write the else branch like this.

skylee03 · 2023-09-07T09:42:35Z

+    @Override
+    public void show(){
+        System.out.print("[D][");
+        if(isDone){


Suggested change

if(isDone){

if (isDone) {

Adding a space before the curly bracket is more consistent with our coding conventions. It is also suggested to add a space after if.

skylee03 · 2023-09-07T10:03:35Z

+
+            else if(keyword.equals("unmark")){
+                // Check exception: number of words is not 2
+                if(words.length != 2){


Suggested change

if(words.length != 2){

if (words.length != 2) {

Adding a space before the curly bracket is more consistent with our coding conventions.

skylee03 · 2023-09-07T10:04:06Z

+            }
+
+            else if(keyword.equals("unmark")){


Suggested change

}

else if(keyword.equals("unmark")){

} else if (keyword.equals("unmark")) {

According to our coding standards, it is recommended to write the else branch like this.

skylee03 · 2023-09-07T10:05:02Z

+    public void show(){
+        System.out.print("[D][");
+        if(isDone){


Suggested change

public void show(){

System.out.print("[D][");

if(isDone){

public void show() {

System.out.print("[D][");

if (isDone) {

Adding a space before the curly bracket is more consistent with our coding conventions.

skylee03 · 2023-09-07T10:06:27Z

-                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+    static private Task[] taskList = new Task[100];


Suggested change

static private Task[] taskList = new Task[100];

static private Task[] tasks = new Task[100];

Plural form should be used on names representing a collection of objects.

skylee03 · 2023-09-07T10:07:16Z

+                    System.out.println("Please enter with correct format: mark [Integer]");
+                }
+                // Check exception: second word cannot be converted to integer or integer out of bounds
+                try{


Suggested change

try{

try {

Adding a space before the curly bracket is more consistent with our coding conventions.

* branch-level5: no message add package chatbot add custom exceptions

irving11119

Generally, your naming conventions are fine and adhere to the coding standards. However, do remember when using braces followed by parenthesis to leave a space in between for proper formatting.

e.g. public void method() {

irving11119 · 2023-09-17T04:22:27Z

@@ -0,0 +1,19 @@
+public class Deadline extends Task{
+    private String deadline;
+    public Deadline(String description, String deadline){


Suggested change

public Deadline(String description, String deadline){

public Deadline(String description, String deadline) {

Similar to most of your methods, do remember to leave a space between the closing parenthesis and the opening curly brace.

irving11119 · 2023-09-17T04:31:03Z

+                try{
+                    int markIndex = Integer.parseInt(words[1]);
+
+                    if(markIndex < 1 || markIndex > numTasks){
+                        System.out.println("Please enter a positive integer less than or equal to current number of tasks (" + numTasks + ")");
+                        continue;
+                    }
+
+                    taskList[markIndex - 1].mark();
+                }
+                catch(NumberFormatException e){
+                    System.out.println("Please enter with correct format: mark [Integer]");
+                }


Try to avoid deep nesting. Instead of deep nesting, you could break down your statements into additional methods.

* branch-Level-6: change storage format of tasks to ArrayList, add delete functionality

Hongzhii added 5 commits September 5, 2023 14:36

update Duke.java

ec3e31b

update Duke.java week3 level1

4012226

add List class

ef6234a

add mark/unmark functionality

1121f60

change structure of tasks

3a479df

implement inheritance for Event, Deadline, Todo classes

skylee03 reviewed Sep 7, 2023

View reviewed changes

Hongzhii added 5 commits September 14, 2023 12:14

modify filepath for runtest.sh

9083cfb

add custom exceptions

f228cbf

add package chatbot

a567a55

no message

c456b01

Merge branch 'branch-level5'

93e46ab

* branch-level5: no message add package chatbot add custom exceptions

irving11119 reviewed Sep 17, 2023

View reviewed changes

Hongzhii and others added 12 commits September 19, 2023 20:31

java coding conventions spacing fix

8f460f2

change storage format of tasks to ArrayList, add delete functionality

03444b5

Merge branch 'branch-Level-6'

c2ffd79

* branch-Level-6: change storage format of tasks to ArrayList, add delete functionality

merge

ab9ab3a

modify deadline and event so that program has correct input format

3e0de87

add two lines

fc6ac44

add text save functionality

303db32

Add find functionality

5c24364

Update README.md

c90b832

Update README.md

6e4e802

add javadoc

067fb41

fix project

a7f0eba

	public class Deadline extends Task{
	public class Deadline extends Task {

	public Deadline(String description, String deadline){
	public Deadline(String description, String deadline) {

	static private Task[] taskList = new Task[100];
	static private Task[] tasks = new Task[100];

Uh oh!

Conversation

Hongzhii commented Sep 6, 2023

Uh oh!

skylee03 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

irving11119 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants