Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

nusmodifications / nusmods Public

Notifications You must be signed in to change notification settings
Fork 356
Star 671

Code
Issues 165
Pull requests 41
Discussions
Actions
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Security and quality
Insights

Remove `withRouter` (2/2)#3009

Merged

taneliang merged 28 commits into

masternusmodifications/nusmods:masterfrom

eliang/even-more-fcnusmodifications/nusmods:eliang/even-more-fcCopy head branch name to clipboard

Dec 7, 2020

Conversation Commits28 (28)Checks Files changed

Merged

Remove `withRouter` (2/2)#3009
taneliang merged 28 commits into
masterfrom
eliang/even-more-fc

Commits

Commits on Dec 3, 2020

Enzyme -> RTL Navtabs.test.tsx
taneliang
committed
Functionalize Navtabs
taneliang
committed
Fix nit in reducer types
taneliang
committed
WIP Enzyme -> RTL ModuleArchiveContainer.test.tsx
taneliang
committed
Fix ModuleArchiveContainer tests and split retryImport into its own file
taneliang
committed
Mock RandomKawaii to reduce noise in test failure messages
taneliang
committed
Reduce test output noise by mocking react-feather in tests
taneliang
committed

Commits on Dec 4, 2020

yarn upgrade @types/react-router-dom
taneliang
committed
Functionalize ModuleArchiveContainer
taneliang
committed
Enzyme -> RTL ModulePageContainer.test.tsx
taneliang
committed
Functionalize ModulePageContainer
taneliang
committed
Rename module-list.json -> module-code-map.jsonn
taneliang
committed

Commits on Dec 5, 2020

Overhaul TimetableContainer.test.tsx with RTL
taneliang
committed
Change getModuleCondensed selector to operate on global Redux state
taneliang
committed
Replace getSemesterTimetable with getSemesterTimetable(Colors|Lessons) selectors
taneliang
committed
Functionalize TimetableContainer
taneliang
committed
Merge branch 'master' into eliang/even-more-fc
taneliang
committed
Remove withRouter and matchBreakpoint hocs from VenueDetails
taneliang
committed
import * as React -> import type { FC } in NoFooter
taneliang
committed

Commits on Dec 6, 2020

Clarify VenueDetails useMediaQuery return variable name
taneliang
committed
Merge branch 'master' into eliang/even-more-fc
taneliang
committed
yarn lint:code --fix
taneliang
committed
Fix noob mistakes in TimetableContainer RTL tests
taneliang
committed
Add mock Axios response in TimetableContainer
taneliang
committed
Fix all noob RTL mistakes in this PR
taneliang
committed
Rename renderResult -> view
taneliang
committed
Increase renderWithRouterMatch param flexibility
taneliang
committed

Commits on Dec 7, 2020

Merge branch 'master' into eliang/even-more-fc
taneliang
authored

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.