-
Notifications
You must be signed in to change notification settings - Fork 356
Add Mobility page for ISBs, MRT info #3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kagiura
wants to merge
14
commits into
nusmodifications:master
Choose a base branch
from
kagiura:kagiura/mobility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2b0bf12
feat: ✨ basic implementation of mobility page (for ISBs)
kagiura f1e5b47
refactor: 🚨 fixed dependency loop + fixed SVCs with gaps during the d…
kagiura 70374d5
refactor: ♻️ refactoring bus apis / util functions
kagiura a679805
refactor: ♻️ separate api errors and actually having no more buses
kagiura 4621d91
chore: 🗃️ update schedule
kagiura 47f1449
fix: 👽️ new proxy api base url added
kagiura 28f5887
refactor: ✨ show which services are directly accessible from any sele…
kagiura 35aebf7
fix: 🐛 bug fixes (auto campus switch, term/holiday distinction)
kagiura c3aefa6
refactor: ♻️ refactored + optimized the isb pages
kagiura c5a8fe6
feat: 🍱 added bus icons (no implementation yet)
kagiura be0b2a8
fix: 🐛 fix mobile having slight horizontal scrolll
kagiura 2df462d
refactor: 💄 only hide footer on desktop (where it doesn't fit)
kagiura 5b9db46
Clean up and fix the build
zwliew e53c1b4
Remove extraneous package.json
zwliew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| const baseURL = 'https://nnextbus.nusmods.com'; // TODO: wait until we have an api proxy | ||
|
|
||
| export const getStopTimings = async ( | ||
| stop: string, | ||
| callback?: (data: ShuttleServiceResult) => void, | ||
| error?: (e: unknown) => void, | ||
| ) => { | ||
| if (!stop) return; | ||
| // TODO: wait until we have an api proxy | ||
| // const API_AUTH = ''; | ||
| try { | ||
| const headers = { | ||
| // headers: { | ||
| // authorization: API_AUTH, | ||
| // accept: 'application/json', | ||
| // }, | ||
| }; | ||
| const response = await fetch(`${baseURL}/ShuttleService?busstopname=${stop}`, headers); | ||
| const data = await response.json(); | ||
| // console.log(data); | ||
| if (callback) callback(data.ShuttleServiceResult); | ||
| } catch (e) { | ||
| // console.error(e); | ||
| if (error) error(e); | ||
| } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this proxy to a serverless function of sorts? Or is something else better?