fix(scrapers): filter out inactive faculties and departments

[ravern]

Summary

• The new API returns all faculties and departments regardless of their active status, unlike the old API which accepted an eff_status: 'A' parameter for server-side filtering
• Added client-side filtering by EffectiveStatus === 'A' for both faculties and departments after fetching (and after the 099 fallback), before the cleanFacultyDepartment mapping

Test plan

• Verify that inactive faculties/departments are excluded from the output
• Verify that the manually-added 099 faculty (which has EffectiveStatus: 'A') is retained
• Verify that facultyDepartments.json output only contains active entries

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
nusmods-export	Ignored	Preview	May 21, 2026 4:45am
nusmods-website	Ignored	Preview	May 21, 2026 4:45am

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.42%. Comparing base (988c6fd) to head (c3a0c68).
⚠️ Report is 228 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4313      +/-   ##
==========================================
+ Coverage   54.52%   56.42%   +1.89%     
==========================================
  Files         274      317      +43     
  Lines        6076     6962     +886     
  Branches     1455     1679     +224     
==========================================
+ Hits         3313     3928     +615     
- Misses       2763     3034     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is a simple, well-placed filter that addresses the API behavior change. The logic is straightforward, type-safe, and preserves the manually-added 099 faculty.
• No files require special attention

Important Files Changed

Filename	Overview
scrapers/nus-v2/src/tasks/GetFacultyDepartment.ts	Added client-side filtering to exclude inactive faculties and departments by EffectiveStatus === 'A'

_{Last reviewed commit: 24e3dca}

[ravern]

This is actually a no-op in terms of data produced, since it looks like there are no inactive faculties/departments.

So the intention here is to just preserve functionality from previous version of scraper.

[jloh02]

Thanks Claude (and Ravern)!