Skip to content

feat: add Twig language support with ASCII art and color scheme#1257

Merged
spenserblack merged 3 commits into
o2sh:mainfrom
arferreira:add-twig-language-support
Apr 10, 2024
Merged

feat: add Twig language support with ASCII art and color scheme#1257
spenserblack merged 3 commits into
o2sh:mainfrom
arferreira:add-twig-language-support

Conversation

@arferreira
Copy link
Copy Markdown
Contributor

@arferreira arferreira commented Jan 20, 2024

Adding support for Twig

#490

Tell me what you think about the proposal

Screenshot 2024-01-20 at 2 16 18 AM

Original logo:

Screenshot 2024-01-20 at 2 17 16 AM

spenserblack
spenserblack approved these changes Jan 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thanks!

Comment thread languages.yaml Outdated
@{0}...........:77:...:~!!!~:.............@{0}
@{0}...........:^^:.......................@{0}
@{0}......................................@{0}
########################################
Copy link
Copy Markdown
Collaborator

@spenserblack spenserblack Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@o2sh what do you think, should these characters be explicitly styled as "white"?

Copy link
Copy Markdown
Contributor Author

@arferreira arferreira Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about?
Screenshot 2024-01-20 at 11 42 23 AM

Copy link
Copy Markdown
Collaborator

@spenserblack spenserblack Jan 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that, instead of just {0} with green, it might be better to have two colors, {0} and {1} for white and green.

@spenserblack spenserblack mentioned this pull request Jan 24, 2024
Closed
@o2sh
Copy link
Copy Markdown
Owner

o2sh commented Mar 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Mar 24, 2024
@arferreira arferreira requested a review from spenserblack March 28, 2024 22:10
spenserblack
spenserblack approved these changes Mar 31, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change I pushed represents the intended style. @arferreira let me know if this is true.

@spenserblack spenserblack merged commit 41c3ecf into o2sh:main Apr 10, 2024
@spenserblack
Copy link
Copy Markdown
Collaborator

spenserblack commented Apr 10, 2024

BTW 😉 spenserblack/gengo#34 (context: #1305)

o2sh added a commit that referenced this pull request Apr 28, 2024
@o2sh
Revert "feat: add Twig language support with ASCII art and color sche…
324f3df 
…me (#1257)"

The ASCII logo needs some rework, I'll revert for now.

This reverts commit 41c3ecf.
@o2sh
Copy link
Copy Markdown
Owner

o2sh commented Apr 28, 2024

The ASCII logo needs some rework. I'll revert it for now and will try to come up with a better design.

Sorry for not stepping in earlier. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spenserblack spenserblack spenserblack approved these changes

@o2sh o2sh Awaiting requested review from o2sh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arferreira @o2sh @spenserblack