Fix Fat dataset loader - #312
Open
amine789 wants to merge 5 commits into
Open
Conversation
oarriaga
reviewed
Sep 1, 2023
Comment on lines
-8
to
-9
| from ..abstract import Loader | ||
| from .utils import get_class_names |
Owner
There was a problem hiding this comment.
please keep the previous conventions of importing from inside paz
| """ | ||
| # TODO: Allow selection of class_names. | ||
| def __init__(self, path, split='train', class_names='all'): | ||
| def __init__(self, path, split=(0.4, 0.4, 0.2), class_names = 'all'): |
Owner
There was a problem hiding this comment.
the variable split is only intended to set to be 'train', 'validation' or 'test'. Please don't change that behavior.
Comment on lines
+68
to
+77
| data_dict = {} | ||
| train_split = int(len(self.data) * self.split[0]) | ||
| test_split = int(len(self.data) * self.split[1]) | ||
| validation_split = int(len(self.data) * self.split[2]) | ||
| data_dict['train'] = self.data[:train_split] | ||
| data_dict['test'] = self.data[ | ||
| train_split:(train_split + test_split)] | ||
| data_dict['validation'] = self.data[(train_split + test_split):] | ||
| return data_dict | ||
|
|
Owner
There was a problem hiding this comment.
One should instantiate a single data loader per dataset.
Comment on lines
+108
to
+110
|
|
||
| fat = Fat('/home/ramit/git/paz') | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.