Skip to content

feat: add oasis rofl set-admin#692

Merged
uniyalabhishek merged 1 commit intomasterfrom
uniyalabhishek/rofl/644-set-admin
Apr 9, 2026
Merged

feat: add oasis rofl set-admin#692
uniyalabhishek merged 1 commit intomasterfrom
uniyalabhishek/rofl/644-set-admin

Conversation

@uniyalabhishek
Copy link
Copy Markdown
Contributor

@uniyalabhishek uniyalabhishek commented Apr 9, 2026

closes #644

docs PREVIEW

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for oasisprotocol-cli ready!

Name Link
🔨 Latest commit 59c8b42
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/69d79f9e16801a00084f139b
😎 Deploy Preview https://deploy-preview-692--oasisprotocol-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@uniyalabhishek uniyalabhishek requested review from matevz and ptrus April 9, 2026 10:38
@uniyalabhishek uniyalabhishek requested a review from matevz April 9, 2026 11:39
Copy link
Copy Markdown
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks. Two more UI and docs suggestions, otherwise LGTM.

@uniyalabhishek uniyalabhishek force-pushed the uniyalabhishek/rofl/644-set-admin branch from 1d12619 to 59c8b42 Compare April 9, 2026 12:46
@uniyalabhishek uniyalabhishek enabled auto-merge April 9, 2026 12:48
@uniyalabhishek uniyalabhishek merged commit e663fe8 into master Apr 9, 2026
5 checks passed
@uniyalabhishek uniyalabhishek deleted the uniyalabhishek/rofl/644-set-admin branch April 9, 2026 12:50
Copy link
Copy Markdown
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a small follow PR.

@@ -0,0 +1 @@
oasis rofl machine set-admin [<machine-name> | <provider-address>:<machine-id>] <new-admin>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples should be executable as it is. If ROFL is configured in the manifest in the current folder, then:

oasis rofl machine set-admin bob

If you want to change the admin of a machine directly:

oasis rofl machine set-admin oasis_playground_provider:0000000000000574 bob

@@ -0,0 +1 @@
oasis rofl set-admin <new-admin>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
oasis rofl set-admin <new-admin>
oasis rofl set-admin bob

Also, direct admin change would also be nice, e.g.

oasis rofl set-admin rofl1... bob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oasis rofl set-admin

2 participants