Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matevz
reviewed
Apr 9, 2026
matevz
approved these changes
Apr 9, 2026
Member
matevz
left a comment
There was a problem hiding this comment.
Works as expected, thanks. Two more UI and docs suggestions, otherwise LGTM.
1d12619 to
59c8b42
Compare
matevz
reviewed
Apr 9, 2026
Member
matevz
left a comment
There was a problem hiding this comment.
Please make a small follow PR.
| @@ -0,0 +1 @@ | |||
| oasis rofl machine set-admin [<machine-name> | <provider-address>:<machine-id>] <new-admin> | |||
Member
There was a problem hiding this comment.
The examples should be executable as it is. If ROFL is configured in the manifest in the current folder, then:
oasis rofl machine set-admin bob
If you want to change the admin of a machine directly:
oasis rofl machine set-admin oasis_playground_provider:0000000000000574 bob
| @@ -0,0 +1 @@ | |||
| oasis rofl set-admin <new-admin> | |||
Member
There was a problem hiding this comment.
Suggested change
| oasis rofl set-admin <new-admin> | |
| oasis rofl set-admin bob |
Also, direct admin change would also be nice, e.g.
oasis rofl set-admin rofl1... bob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #644
docs PREVIEW