Update eth_getStorageAt docs with whitelisted storage slots#588
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I was about to update the hyperlane docs, to no use the branch pb/storage-workaround and make the custom modifications on top of the current main branch. Let me add it to this branch. |
|
This should now finally be live on testnet. Can someone try it out? @rube-de ? |
|
I tried it with the unchanged Hyperlane CLI to the deploy the core contracts, which uses eth_getStorageAt for the implementation slot it fails with |
|
Is that on testnet? Because I just tested getStorageAt on testnet (on my test contract) and it works: |
|
But for oh maybe it expects a different value when empty? (e.g. maybe not stripped, but 0x0000...). I remember such cases in past with some apps. |
1d30078 to
7f3f586
Compare
|
@rube-de can you please retry this? The testnet gateways were just updated to now return non-stripped zero values which is more standard and compatible with various clients (oasisprotocol/oasis-web3-gateway#595). This should fix the error you posted above:
|
|
I ran again |
|
Nice! Let's wait for the next Sapphire Mainnet release, then we can merge the updates. |
|
This should also be live on mainnet now, so let's merge it. |
7f3f586 to
9d24e21
Compare
Merge once Sapphire with oasisprotocol/oasis-sdk#2215 is live.