Skip to content

simplify get_bitinformation#262

Merged
observingClouds merged 4 commits intomainfrom
fix_261
Apr 3, 2025
Merged

simplify get_bitinformation#262
observingClouds merged 4 commits intomainfrom
fix_261

Conversation

@observingClouds
Copy link
Copy Markdown
Owner

fixes eventually #261

@observingClouds observingClouds force-pushed the fix_261 branch 4 times, most recently from 1b323c8 to ee43302 Compare February 10, 2024 00:16
@thodson-usgs
Copy link
Copy Markdown

thodson-usgs commented Sep 9, 2024

Any plan to continue on this? Trying to decide whether and how best to resume: zarr-developers/numcodecs#503

I had advocated for a pure numpy implementation of the bitinfo algorithm that would eventually be included in xbitinfo and from there imported into numcodec, but perhaps that was jumping ahead... An alternative would be to just import the xarray-based implementation from xbitinfo, use that in the codec, but make the module optional until we have a pure numpy implementation: check if xarray is installed and throw and error if it isn't.

On the xbitinfo end. Ideally, we only maintain a single version of the algorithm. I think a numpy implementation might replace the lower-level implementation, where xarray doesn't seem as well suited, but there would still be the same high-level xarray interface wrapping it.

@observingClouds
Copy link
Copy Markdown
Owner Author

Thanks @thodson-usgs, yes I do plan to continue this PR, hopefully I come back to this within the next weeks.

@observingClouds observingClouds marked this pull request as ready for review April 2, 2025 16:00
@observingClouds
Copy link
Copy Markdown
Owner Author

Finally I am back to this PR. The get_bitinformation function is now simplified and no longer excluded from inspection.

@thodson-usgs
Copy link
Copy Markdown

The delay was worthwhile. Zarr V3 will support 3rd party codecs.

@observingClouds observingClouds merged commit c05dd42 into main Apr 3, 2025
11 checks passed
@observingClouds observingClouds deleted the fix_261 branch April 3, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants