You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had advocated for a pure numpy implementation of the bitinfo algorithm that would eventually be included in xbitinfo and from there imported into numcodec, but perhaps that was jumping ahead... An alternative would be to just import the xarray-based implementation from xbitinfo, use that in the codec, but make the module optional until we have a pure numpy implementation: check if xarray is installed and throw and error if it isn't.
On the xbitinfo end. Ideally, we only maintain a single version of the algorithm. I think a numpy implementation might replace the lower-level implementation, where xarray doesn't seem as well suited, but there would still be the same high-level xarray interface wrapping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes eventually #261