Skip to content

Added warning for NaNs#264

Closed
Bhairvi23 wants to merge 5 commits intoobservingClouds:mainfrom
Bhairvi23:CheckforNaNs
Closed

Added warning for NaNs#264
Bhairvi23 wants to merge 5 commits intoobservingClouds:mainfrom
Bhairvi23:CheckforNaNs

Conversation

@Bhairvi23
Copy link
Copy Markdown

Added warning for the first encountered NaN value.
Closes #200

@observingClouds
Copy link
Copy Markdown
Owner

Hi @Bhairvi23,
Thank you for your first contribution to xbitinfo 🎉 The PR looks good so far and the failure seems to come from the newest changes to xarray. Before this contribution can be merged we need to do a few more things:

  • remove the .DS_Store file that has been accidentally been committed
  • add your changes to the CHANGELOG.md
  • add a simple test to check whether or not the warning will actually be raised.

@observingClouds
Copy link
Copy Markdown
Owner

@Bhairvi23 I just updated your branch with a fix for the doctests. Now the tests all pass 🎉 If you could address above mentioned points we are ready to merge this.

@Bhairvi23
Copy link
Copy Markdown
Author

@observingClouds I am unable to find the .DS_Store file. I can see that there has been some changes but I cant seem to locate it.

@observingClouds
Copy link
Copy Markdown
Owner

Hi @Bhairvi23 ,
The file is likely hidden on your system. You can see it with ls -a. To remove the file from your PC and the git you could do git rm .DS_store and commit the changes afterwards as usual.

@milankl
Copy link
Copy Markdown
Collaborator

milankl commented Feb 26, 2024

.DS_Store is a hidden file that macos creates to store information of how to visualise a folder (e.g. list vs icons). It can generally be put into .gitignore

@milankl
Copy link
Copy Markdown
Collaborator

milankl commented Feb 26, 2024

The .DS_Store file is still in the commits though, @Bhairvi23 can you try to delete it? It doesn't show up for me for some reason...

@observingClouds
Copy link
Copy Markdown
Owner

Sry @Bhairvi23 I just recognise that this issue will already be addressed with #260 which was unfortunately not linked to #200

@Bhairvi23 Bhairvi23 deleted the CheckforNaNs branch February 27, 2024 00:04
@Bhairvi23 Bhairvi23 restored the CheckforNaNs branch May 4, 2024 09:00
@Bhairvi23 Bhairvi23 deleted the CheckforNaNs branch May 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for NaNs and raise warning

3 participants