Fix/typos and variable name#163
Open
semnil wants to merge 2 commits intoobsproject:masterfrom
Open
Conversation
The debug flag was appended to a non-existent `build_args` variable instead of `package_args` in the Ubuntu packaging step of package-plugin action. This caused the `--debug` flag to be silently lost when RUNNER_DEBUG is enabled. The macOS step in the same file correctly uses `package_args`.
"Reelase" to "Release".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build_argstopackage_argsin Ubuntu packaging step of package-plugin action. The--debugflag was being appended to a non-existent variable instead of thepackage_argsarray that is passed to the packaging script.Motivation and Context
Found these issues while working on adding InnoSetup installer support to a plugin project based on this template.
How Has This Been Tested?
Types of changes
Checklist: