libobs/util,text-freetype2: Permit internal nulls#11045
Open
kkartaltepe wants to merge 1 commit intoobsproject:masterfrom
Open
libobs/util,text-freetype2: Permit internal nulls#11045kkartaltepe wants to merge 1 commit intoobsproject:masterfrom
kkartaltepe wants to merge 1 commit intoobsproject:masterfrom
Conversation
Fixes handling of text to attempt to parse past the first null character when buffer sizes are known and correct some length handling throughout the plugin. Fixes obsproject#7595
4 tasks
Member
|
Triage note: Need to determine if this or #13093 is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes handling of text to attempt to parse past the first null character when buffer sizes are known and correct some length handling throughout the plugin.
This probably makes unmeasured conversion twice as slow. Since it introduces a
wcslen()/strlen()into the conversion routine that was previously just done during conversion. Maybe reintegrating that is a good first issue for someone :)Largely just #7622 but with some fixes that were found during review.
Motivation and Context
Fixes #7595
How Has This Been Tested?
utf-8 example file from the issue is fixed.
utf16 is blank instead of being a bunch of broken characters and possibly overrunning buffers, presumably windows will continue working.
It probably needs a second or third set of eyes.
Types of changes
Checklist: