Skip to content

frontend: Make sure all QObject subclasses have Q_OBJECT macro#12115

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
cg2121:more-qobject-macros
May 5, 2025
Merged

frontend: Make sure all QObject subclasses have Q_OBJECT macro#12115
RytoEX merged 1 commit intoobsproject:masterfrom
cg2121:more-qobject-macros

Conversation

@cg2121
Copy link
Copy Markdown
Contributor

@cg2121 cg2121 commented May 2, 2025

Description

Went through and found all QObject subclasses that didn't have a Q_OBJECT macro.

Motivation and Context

#11784 still doesn't compile

How Has This Been Tested?

It compiled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 requested a review from PatTheMav May 2, 2025 07:15
@cg2121 cg2121 added the kind/bug Categorizes issue or PR as related to a bug. label May 2, 2025
Comment thread frontend/components/DelButton.hpp
Went through and found all QObject subclasses that didn't have
a Q_OBJECT macro.
@cg2121 cg2121 force-pushed the more-qobject-macros branch from 43867fd to 6bc35ad Compare May 5, 2025 16:40
@cg2121 cg2121 requested a review from RytoEX May 5, 2025 16:40
@RytoEX RytoEX merged commit 345fe56 into obsproject:master May 5, 2025
15 checks passed
@RytoEX RytoEX added this to the OBS Studio 31.1 milestone May 5, 2025
@cg2121 cg2121 deleted the more-qobject-macros branch May 5, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants