frontend: Make OBSAbout self contained#12202
Open
cg2121 wants to merge 1 commit intoobsproject:masterfrom
Open
frontend: Make OBSAbout self contained#12202cg2121 wants to merge 1 commit intoobsproject:masterfrom
cg2121 wants to merge 1 commit intoobsproject:masterfrom
Conversation
cg2121
added
area/ui-ux
cg2121
force-pushed
the
obsbasic-defriend-obsabout
branch
2 times, most recently
from
a9086a3 to
112b814
Compare
cg2121
changed the title
cg2121
force-pushed
the
obsbasic-defriend-obsabout
branch
from
112b814 to
5a19707
Compare
PatTheMav
reviewed
May 24, 2025
Member
PatTheMav
left a comment
PatTheMav
left a comment
There was a problem hiding this comment.
So this encapsulates the management (and updating) of the patronJSON entirely into the OBSAbout class? Nice.
Why does it need to include OBSApp though?
Contributor
Author
|
It is needed for the GetDataFilePath function. OBSApp.hpp was included with OBSBasic.hpp before. |
PatTheMav
reviewed
May 30, 2025
gxalpha
reviewed
Jun 16, 2025
Member
|
This has a merge conflict. cc @Warchamp7 |
RytoEX
moved this from In Review
to Requires Changes
in OBS Studio 32.1 PR Considerations
Warchamp7
force-pushed
the
obsbasic-defriend-obsabout
branch
from
5a19707 to
142353d
Compare
Member
Rebased |
Warchamp7
force-pushed
the
obsbasic-defriend-obsabout
branch
from
142353d to
8761377
Compare
Member
|
Now featuring 100% less accidental submodule commits. |
RytoEX
requested changes
May 5, 2026
Member
|
Might have a conflict with #12934 since that changes some stuff regarding RemoteTextThread. |
6 tasks
Member
|
Now that #12934 is merged, please resolve merge conflicts and ensure that this still functions as intended after changes to RemoteTextThread. |
This makes it so OBSAbout isn't tangled with OBSBasic.
cg2121
force-pushed
the
obsbasic-defriend-obsabout
branch
from
8761377 to
e55b2ec
Compare
Contributor
Author
|
I fixed the merge conflicts and made sure it still works with the changes to the RemoteTextThread. |
RytoEX
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes it so OBSAbout isn't tangled with OBSBasic.
Motivation and Context
Make frontend less messy
How Has This Been Tested?
Opened about dialog to make sure it still worked
Types of changes
Checklist: