Skip to content

frontend: Demangle ScreenshotObj and OBSBasic#13037

Open
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:demangle-screenshot2
Open

frontend: Demangle ScreenshotObj and OBSBasic#13037
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:demangle-screenshot2

Conversation

@Warchamp7
Copy link
Copy Markdown
Member

Description

This adds a signal to ScreenshotObj so it doesn't have to directly call OBSBasic. Updated after the changes due to the Add Source dialog.

Revised version that supersedes #12186

Motivation and Context

Less friends for OBSBasic and better code.

How Has This Been Tested?

Took screenshots to make sure they still worked.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 added kind/cleanup Non-breaking change which makes code smaller or more readable area/ui-ux Anything to do with changes or additions to UI/UX elements. labels Jan 16, 2026
Comment thread frontend/widgets/OBSBasic.hpp Outdated
Comment thread frontend/widgets/OBSBasic_Screenshots.cpp
@Warchamp7 Warchamp7 added this to the OBS Studio 32.2 milestone May 6, 2026
@RytoEX
Copy link
Copy Markdown
Member

RytoEX commented May 7, 2026

This currently has merge conflicts.

@Warchamp7 Warchamp7 force-pushed the demangle-screenshot2 branch 2 times, most recently from 0b2cfe8 to c2a787e Compare May 8, 2026 02:05
@Warchamp7
Copy link
Copy Markdown
Member Author

This currently has merge conflicts.

Fixed.

Co-Authored-By: Clayton Groeneveld <19962531+cg2121@users.noreply.github.com>
@Warchamp7 Warchamp7 force-pushed the demangle-screenshot2 branch from c2a787e to 548c3d1 Compare May 8, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants