Skip to content

cmake: Fix dependency download logic #13078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhangboyang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmake: Fix dependency download logic #13078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmake/common/buildspec_common.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,16 @@ function(_check_dependencies)

if(NOT EXISTS "${dependencies_dir}/${file}")
message(STATUS "Downloading ${url}")
file(DOWNLOAD "${url}" "${dependencies_dir}/${file}" STATUS download_status EXPECTED_HASH SHA256=${hash})
file(DOWNLOAD "${url}" "${dependencies_dir}/${file}.tmp" STATUS download_status EXPECTED_HASH SHA256=${hash})

list(GET download_status 0 error_code)
list(GET download_status 1 error_message)
if(error_code GREATER 0)
if(error_code)
file(REMOVE "${dependencies_dir}/${file}.tmp")
message(STATUS "Downloading ${url} - Failure")
message(FATAL_ERROR "Unable to download ${url}, failed with error: ${error_message}")
file(REMOVE "${dependencies_dir}/${file}")
else()
file(RENAME "${dependencies_dir}/${file}.tmp" "${dependencies_dir}/${file}")
message(STATUS "Downloading ${url} - done")
endif()
endif()
Expand Down