Skip to content

plugins: Remove legacy slideshow source#13380

Open
cg2121 wants to merge 1 commit intoobsproject:masterfrom
cg2121:remove-old-slideshow
Open

plugins: Remove legacy slideshow source#13380
cg2121 wants to merge 1 commit intoobsproject:masterfrom
cg2121:remove-old-slideshow

Conversation

@cg2121
Copy link
Copy Markdown
Contributor

@cg2121 cg2121 commented May 1, 2026

Description

This removes the old slideshow source. Since the properties are the same for both of the new and old slideshows, they are backwards compatible.

Motivation and Context

It is just extra code that is not need.

How Has This Been Tested?

Created slideshow with old source and made sure it migrated to the new one.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added the kind/cleanup Non-breaking change which makes code smaller or more readable label May 1, 2026
Comment thread plugins/image-source/obs-slideshow-mk2.c
@Warchamp7
Copy link
Copy Markdown
Member

What happens to a Slideshow v1 and v2 in a scene collection after these changes?

I presume they're simply treated as the same thing which begs the question of why v1 was ever retained in the first place?

This removes the old slideshow source. Since the properties are
the same for both of the new and old slideshows, they are
backwards compatible.
@cg2121 cg2121 force-pushed the remove-old-slideshow branch from aa0456f to 8994e8b Compare May 4, 2026 15:47
@cg2121
Copy link
Copy Markdown
Contributor Author

cg2121 commented May 4, 2026

I've added back the original slideshow_info struct, so users with old versions can seamlessly upgrade to the new source.

As an aside, we need to replace the versioning system, as it produces so much duplicate code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants