cmake: Switch preset to VS 2026#13392
Open
thomasza92 wants to merge 1 commit into
Open
Conversation
Updates the Visual Studio generator in CMakePresets.json from Visual Studio 2022 to Visual Studio 2026.
Member
|
Noting that indeed Microsoft no longer offers Visual Studio Community 2022 and anyone getting started with development using the Community version will have to use 2026. However as evidenced by the failed check, the presets are also used by the build workflows. GitHub runners are still only in public preview for VS2026 for the time being. I'd recommend that people set up a |
|
This is my current cmake configure and build command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Visual Studio generator in CMakePresets.json from Visual Studio 2022 to Visual Studio 2026. This would be a breaking change for anyone still on Visual Studio 2022 and would require them to update.
Motivation and Context
In order to build from source using the newest version of Visual Studio this line had to be updated. Many people may still be on Visual Studio 2022 but I am not sure that this version is still available to download from Microsoft. At some point in the future this will eventually need to be updated.
How Has This Been Tested?
I used it myself to build OBS from source on Windows 11 using Visual Studio 2026 Enterprise Edition.
Types of changes
Checklist: