Skip to content

obs-webrtc: Allow B-frames for AV1 #13393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bleuzen wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

obs-webrtc: Allow B-frames for AV1 #13393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/utility/AdvancedOutput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ void AdvancedOutput::UpdateStreamSettings()
if (applyServiceSettings) {
int bitrate = (int)obs_data_get_int(settings, "bitrate");
int keyint_sec = (int)obs_data_get_int(settings, "keyint_sec");
obs_data_set_string(settings, "codec", obs_get_encoder_codec(streamEncoder));
obs_service_apply_encoder_settings(main->GetService(), settings, nullptr);
if (!enforceBitrate) {
int maxVideoBitrate;
Expand Down
1 change: 1 addition & 0 deletions frontend/utility/SimpleOutput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ void SimpleOutput::Update()
obs_data_set_string(audioSettings, "rate_control", "CBR");
obs_data_set_int(audioSettings, "bitrate", audioBitrate);

obs_data_set_string(videoSettings, "codec", obs_get_encoder_codec(encoder_id));
obs_service_apply_encoder_settings(main->GetService(), videoSettings, audioSettings);

if (!enforceBitrate) {
Expand Down
6 changes: 5 additions & 1 deletion plugins/obs-webrtc/whip-service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ void WHIPService::ApplyEncoderSettings(obs_data_t *video_settings, obs_data_t *)
{
// For now, ensure maximum compatibility with webrtc peers
if (video_settings) {
obs_data_set_int(video_settings, "bf", 0);
const char *codec = obs_data_get_string(video_settings, "codec");
bool isAv1 = strcmp(codec, "av1") == 0;
if (!isAv1) {
obs_data_set_int(video_settings, "bf", 0);
}
obs_data_set_bool(video_settings, "repeat_headers", true);
}
}
Expand Down
Loading