Skip to content

obs-webrtc: Add 512Kb limit for WHIP Responses#13408

Open
Sean-Der wants to merge 1 commit intoobsproject:masterfrom
Sean-Der:whip-response-limit
Open

obs-webrtc: Add 512Kb limit for WHIP Responses#13408
Sean-Der wants to merge 1 commit intoobsproject:masterfrom
Sean-Der:whip-response-limit

Conversation

@Sean-Der
Copy link
Copy Markdown
Contributor

@Sean-Der Sean-Der commented May 6, 2026

Description

Add a 512Kb limit on HTTP Responses from WHIP servers.

Motivation and Context

Fail earlier before we pass into libdatachannel.

How Has This Been Tested?

Tested against https://b.siobud.com so happy case still works.

Ran broadcast box locally and added lots of padding and confirmed error handling works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested review from DDRBoxman and tt2468 May 6, 2026 18:53
Comment thread plugins/obs-webrtc/whip-utils.h Outdated
@Sean-Der Sean-Der force-pushed the whip-response-limit branch from aebca57 to 8c661e9 Compare May 6, 2026 19:18
@Sean-Der Sean-Der requested a review from notr1ch May 6, 2026 19:18
Comment thread plugins/obs-webrtc/whip-utils.h Outdated
@Sean-Der Sean-Der force-pushed the whip-response-limit branch from 8c661e9 to 45a450e Compare May 7, 2026 16:28
@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants