Add relocatable ocamlbuild.0.16.1, patched to remove a symlink - #10
Closed
ElectreAAS wants to merge 2 commits into
Closed
Add relocatable ocamlbuild.0.16.1, patched to remove a symlink#10ElectreAAS wants to merge 2 commits into
ElectreAAS wants to merge 2 commits into
Conversation
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Author
|
cc @Alizter as I can't add you as reviewer for some reason |
Contributor
|
As we discussed, is it possible to add separate patch files rather than point to a fork? |
This was referenced Mar 11, 2026
…xtra-source Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Author
|
This is done in the latest commit, but please don't merge too quickly, I'm running a test batch to make sure it's working |
ElectreAAS
marked this pull request as draft
March 11, 2026 17:23
Author
|
I am closing this as no longer needed, since ocaml/dune#13792 is merged and ocaml/dune#9873 is closed, see reasoning there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In dra27/ocamlbuild#3, I ran a lot of builds on the dependents of ocamlbuild, with and without Steve's patch (link to the specific commit), and to my surprise the patch didn't help in any meaningful way. It seems the problem this commit was supposed to fix was also fixed by David separately.
The second commit on Steve's repo is only useful as a workaround for dune, so it wouldn't make sense to upstream it.
What this PR does
OCAMLBUILD_LIBDIRfix which is present on David's repoAlternate route
If merging this PR is not seen as a good move, another option is to add my fork of the overlays to the default repositories in the dune code