fix(meta): reject malformed META file templates - #15994
Draft
Alizter wants to merge 4 commits into
Draft
Conversation
Alizter
marked this pull request as ready for review
August 17, 2026 11:53
Alizter
marked this pull request as draft
August 17, 2026 12:16
Alizter
force-pushed
the
push-mwwrkvzmlnuu
branch
from
August 17, 2026 15:46
08bf337 to
c6ca494
Compare
Alizter
force-pushed
the
push-mwwrkvzmlnuu
branch
3 times, most recently
from
August 17, 2026 16:54
bfebadf to
d4593a5
Compare
Alizter
force-pushed
the
push-mwwrkvzmlnuu
branch
from
August 17, 2026 20:58
d4593a5 to
4b7d48c
Compare
This was referenced Aug 17, 2026
Alizter
force-pushed
the
push-mwwrkvzmlnuu
branch
3 times, most recently
from
August 18, 2026 11:14
d5f8055 to
8c40129
Compare
A META file template can parse before expansion and become malformed when a later generation marker is replaced. Snapshot that behavior and the presence of multiple markers. Signed-off-by: Ali Caglayan <alizter@gmail.com>
A promoted META file template can differ from a stale source counterpart. Snapshot acceptance of the generated build contents when promotion is disabled. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Verify that the accepted malformed source template reaches both the generated and installed META files before validation is added. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Validate exact template contents before and after rendering, preserve structured source and build diagnostics, and attribute expansion failures to the responsible generation marker. Escape generated backslashes so rendered metadata round-trips through META parsing. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-mwwrkvzmlnuu
branch
from
August 18, 2026 12:01
8c40129 to
5f5e311
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #16004, #16006, and #16016. Main already contains the generated-template, backslash, and virtual-library ordering regressions from #16005, #16007, and #16008.
Validate exact META file template contents before and after rendering. Preserve source/build origins and structured diagnostics, attribute rendered failures to the responsible marker, keep virtual-library checks ahead of template actions, and escape generated backslashes.
Test:
dune runtest test/blackbox-tests/test-cases/meta-file