Skip to content

test(pkg): preserve per-platform alternative selections - #15998

Merged
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-xqnrpynumlwl
Aug 17, 2026
Merged

test(pkg): preserve per-platform alternative selections#15998
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-xqnrpynumlwl

Conversation

@Alizter

@Alizter Alizter commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a portable lock-directory regression for an unfiltered dependency alternative whose implementations are available on different platforms.
  • Assert that locking preserves the implementation selected for each platform.
  • Build the resulting lock directory on Linux and macOS to cover consumption as well as the lock summary.

This snapshots the existing per-platform selection invariant before the joint-solver change in #15982.

Tests

  • nix develop -c dune runtest test/blackbox-tests/test-cases/pkg/portable-lockdirs/portable-lockdirs-platform-alternative-selection.t
  • CI=true nix develop -c dune build @fmt @check

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter added package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands no changelog labels Aug 17, 2026
@Alizter
Alizter marked this pull request as draft August 17, 2026 18:04
@Alizter
Alizter marked this pull request as ready for review August 17, 2026 18:06
@Alizter
Alizter merged commit 475cde3 into ocaml:main Aug 17, 2026
55 of 66 checks passed
@Alizter
Alizter deleted the push-xqnrpynumlwl branch August 17, 2026 18:06
@Alizter Alizter added this to the 3.25.0 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant