Skip to content

test(pkg): preserve platform-specific rejection reasons - #16000

Merged
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-xmmksoqlwvxn
Aug 17, 2026
Merged

test(pkg): preserve platform-specific rejection reasons#16000
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-xmmksoqlwvxn

Conversation

@Alizter

@Alizter Alizter commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a portable lock-directory regression for a package that exists in the repository but is unavailable on Linux.
  • Assert that the solver reports Availability condition not satisfied for the requested Linux platform.
  • Guard against reconstructing rejection reasons in a platform-less environment.

This is an independent test-only baseline for the joint-solver work in #15982.

Tests

  • nix develop -c dune runtest test/blackbox-tests/test-cases/pkg/portable-lockdirs/portable-lockdirs-platform-rejection-reason.t
  • CI=true nix develop -c dune build @fmt @check

@Alizter Alizter added package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands no changelog labels Aug 17, 2026
@Alizter
Alizter marked this pull request as draft August 17, 2026 18:04
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Alizter force-pushed the push-xmmksoqlwvxn branch from d0dd900 to 893c3f0 Compare August 17, 2026 18:44
@Alizter
Alizter marked this pull request as ready for review August 17, 2026 19:39
@Alizter
Alizter merged commit 536ca70 into ocaml:main Aug 17, 2026
36 checks passed
@Alizter
Alizter deleted the push-xmmksoqlwvxn branch August 17, 2026 22:48
@Alizter Alizter added this to the 3.25.0 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant