Skip to content

test(meta): snapshot malformed promoted template acceptance #16006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alizter wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −0
Open

test(meta): snapshot malformed promoted template acceptance #16006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions test/blackbox-tests/test-cases/meta-file/promoted-template.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
A promoted META file template may have a source counterpart that differs from
the rule output. The generated contents are currently accepted.

$ make_dune_project_with_package 2.7 promoted

$ cat >promoted.ml <<EOF
> let foo () = ()
> EOF

$ cat >META.promoted.template <<EOF
> # DUNE_GEN
> EOF

$ cat >dune <<'EOF'
> (library
> (public_name promoted))
>
> (rule
> (target META.promoted.template)
> (mode promote)
> (action
> (write-file %{target} "package \"broken\" @")))
> EOF

$ dune build @install --disable-promotion

The source remains valid, while the generated template and final META contain
the malformed rule output.

$ printf '# DUNE_GEN\n' | cmp - META.promoted.template
$ printf 'package "broken" @' | cmp - _build/default/META.promoted.template
$ printf 'package "broken" @' | cmp - _build/default/META.promoted
Loading