Refresh build status line periodically - #16015
Draft
Alizter wants to merge 2 commits into
Draft
Conversation
Member
|
Something is fishy in this PR Why would it be necessary to cancel the timer that is updating the status line? Why do we need the additional optimizations on top if we're updating the status five times a second? |
Alizter
force-pushed
the
refresh-build-status-timer
branch
from
August 17, 2026 22:59
cd56cce to
d2ce3c3
Compare
Collaborator
Author
You're right, it's completely unnecessary and was the cause of the performance issue I was trying to prematurely optimise. I've replaced it with something much simpler. I will iterate on it a bit further as I get the time. |
Alizter
force-pushed
the
refresh-build-status-timer
branch
from
August 18, 2026 12:06
d2ce3c3 to
ea6e9ed
Compare
Alizter
force-pushed
the
refresh-build-status-timer
branch
from
August 18, 2026 12:43
ea6e9ed to
b682275
Compare
Alizter
force-pushed
the
refresh-build-status-timer
branch
from
August 18, 2026 13:10
b682275 to
ff35947
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
refresh-build-status-timer
branch
from
August 18, 2026 14:05
ff35947 to
b141269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build duration in the status line currently advances only when another
scheduler event redraws the line. During long-running rules it can therefore
appear frozen.
This change installs a scheduler-owned 200 ms periodic timer in the async I/O
loop. Each tick sends a coalesced, lowest-priority status-line refresh event.
The event wakes an idle scheduler, while ordinary scheduler events subsume a
pending refresh. Rendering continues to run on the scheduler thread through
the existing status-line refresh hook.
The timer's lifetime is tied to the async I/O loop and it is stopped and
destroyed during scheduler shutdown. No console backend or progress renderer
changes are needed.
Tests:
./_boot/dune.exe runtest test/blackbox-tests/test-cases/status-line-refresh.t --forcedune build bin/main.exedune runtest test/blackbox-tests/test-cases/watching/rpc-build-status-line.t